Skip to content
This repository was archived by the owner on Dec 2, 2024. It is now read-only.

Conversation

@malhotra5
Copy link
Collaborator

@malhotra5 malhotra5 commented Nov 12, 2024

This PR implements the last requirement for #232

Summary

This will check the body, review threads, review comments, or general comments on PRs for references to issues/PRs.

All these references are collected and duplicates are removed. Then the issue bodies are collected and included in the agent's context underneath # Issues addressed.

NOTE: if the @openhands-macro is used, all comments are filtered except for the one where the macro is used. In this case, any issues references in the macro comment or the PR body will be included. References in OTHER comments will be disregarded.

@malhotra5 malhotra5 marked this pull request as draft November 12, 2024 22:25
1. checking correct issues refs are included when comment_id is present

2. checking that duplicates issues refs are not included multiple times
@malhotra5 malhotra5 requested a review from neubig November 12, 2024 22:39
@malhotra5 malhotra5 marked this pull request as ready for review November 12, 2024 22:39
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@malhotra5 malhotra5 merged commit 919ad17 into main Nov 12, 2024
@malhotra5 malhotra5 deleted the referenced-context branch November 12, 2024 23:22
neubig pushed a commit that referenced this pull request Nov 13, 2024
* grabbing bodies for referenced issues in comment bodies

* considering thread comments for issue refs

* updating tests

* adding tests for external issue refs

1. checking correct issues refs are included when comment_id is present

2. checking that duplicates issues refs are not included multiple times
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants